Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some general maintenance #303

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Some general maintenance #303

merged 2 commits into from
Oct 13, 2023

Conversation

andreasnoack
Copy link
Member

  • Import stack from Base starting with Julia 1.9
  • Switch from DataAPI.All to Cols and use values to extract from kwargs

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (def7137) 82.69% compared to head (7e97ebb) 87.60%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
+ Coverage   82.69%   87.60%   +4.91%     
==========================================
  Files          15       15              
  Lines        1277     1759     +482     
==========================================
+ Hits         1056     1541     +485     
+ Misses        221      218       -3     
Files Coverage Δ
src/IndexedTables.jl 87.50% <ø> (+27.50%) ⬆️
src/columns.jl 89.68% <100.00%> (+7.91%) ⬆️
src/reduce.jl 88.63% <66.66%> (+4.85%) ⬆️
src/selection.jl 83.87% <50.00%> (-2.50%) ⬇️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreasnoack andreasnoack merged commit f83f0c7 into main Oct 13, 2023
5 of 6 checks passed
@andreasnoack andreasnoack deleted the an/fixes branch October 13, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant