Get reshape functions working, add tests #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very cool. I still don't see why this interface is better than that used by R's reshape package. What do you think? |
|
Good question -- I haven't used them much, so I'd have to compare directly to form an opinion -- I'll take a look in the morning. |
|
Well, let's merge the cleanup whenever you're ready. Then we can debate interfaces. |
garborg
added a commit
that referenced
this pull request
Jul 10, 2014
Get reshape functions working, add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pivottableuses a function that had been removed.unstackargments had names swapped, and inconsistent across methods.stackdfandmeltdfwere inserting stray values into the head of the value column.