Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover corner case of compactype (wide name and CategoricalValue) #2751

Merged
merged 1 commit into from
May 17, 2021

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented May 7, 2021

@nalimilan - following your query in #2750 I have improved test coverage 😄.

@bkamins bkamins requested a review from nalimilan May 7, 2021 11:27
@bkamins bkamins added this to the patch milestone May 7, 2021
@bkamins
Copy link
Member Author

bkamins commented May 17, 2021

bump (this should be quick to review :))

Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops. Thanks!

@nalimilan nalimilan merged commit e230855 into main May 17, 2021
@nalimilan nalimilan deleted the improve_compacttype_coverage branch May 17, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants