Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CategoricalArrays.jl in Project.toml #2646

Merged
merged 2 commits into from
Mar 6, 2021
Merged

Fix CategoricalArrays.jl in Project.toml #2646

merged 2 commits into from
Mar 6, 2021

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Mar 6, 2021

@KristofferC - I have a question regarding Project.toml.

If a package is in [extras] then is [compat] entry allowed for it?

In https://julialang.github.io/Pkg.jl/v1/toml-files/#The-[compat]-section it is stated that only [deps] entries are allowed in [compat], but maybe also [extras] are allowed and the description given there should be fixed? Thank you!

@simeonschaub
Copy link

If a package is in [extras] then is [compat] entry allowed for it?

Yes, that should work.

@bkamins bkamins added the CI label Mar 6, 2021
@bkamins bkamins added this to the 1.0 milestone Mar 6, 2021
@bkamins
Copy link
Member Author

bkamins commented Mar 6, 2021

So I understand the documentation in Pkg.jl should be fixed - right?

@simeonschaub
Copy link

Yes. Could you open an issue?

@bkamins
Copy link
Member Author

bkamins commented Mar 6, 2021

JuliaLang/Pkg.jl#2424

@@ -24,7 +23,7 @@ Tables = "bd369af6-aec1-5ad0-b16a-f7cc5008161c"
Unicode = "4ec0a83e-493e-50e2-b9ac-8f72acf5a8f5"

[compat]
CategoricalArrays = "0.8.3, 0.9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need 0.9?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need 0.9.3 for unwrap

@bkamins bkamins merged commit c8f1281 into main Mar 6, 2021
@bkamins bkamins deleted the bkamins-patch-1 branch March 6, 2021 19:22
@bkamins
Copy link
Member Author

bkamins commented Mar 6, 2021

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants