Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Change stack to create a PooledArray{String} column by default #2391

Merged
merged 5 commits into from
Aug 31, 2020

Commits on Aug 29, 2020

  1. Change stack to create a PooledArray{String} column by default

    This is less likely to confuse users (it's the dplyr and pandas default),
    and it would allow dropping the dependency on CategoricalArrays if we wanted to.
    The drawback of returning strings is that the order of old columns is only
    reflected by the order of rows, and no longer by the sorting order of levels.
    
    Also return a `PooledArray{Symbol}` when `variable_eltype=Symbol` is passed.
    That's more consistent and more efficient, e.g. if you want to group on symbols
    later.
    
    Any element type is now accepted, with `CategoricalValue{String}` being handled
    by the general path. In practice it would allow using a custom `AbstractString`
    type, though that's relatively unlikely.
    nalimilan committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    6a640fd View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2020

  1. Use ===

    nalimilan committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    a4bb506 View commit details
    Browse the repository at this point in the history
  2. Fixes

    nalimilan committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    95ee656 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. Configuration menu
    Copy the full SHA
    4e86a1e View commit details
    Browse the repository at this point in the history
  2. Fixes

    nalimilan committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    918d734 View commit details
    Browse the repository at this point in the history