Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add columnindex for DataFrameRow, speed up columnindex, fix a bug in indexing #2380

Merged
merged 4 commits into from
Aug 24, 2020

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Aug 24, 2020

Fixes #2379

@bkamins bkamins added bug feature performance non-breaking The proposed change is not breaking labels Aug 24, 2020
@bkamins bkamins added this to the 1.0 milestone Aug 24, 2020
src/other/tables.jl Outdated Show resolved Hide resolved
test/indexing.jl Outdated Show resolved Hide resolved
test/indexing.jl Outdated Show resolved Hide resolved
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
@bkamins
Copy link
Member Author

bkamins commented Aug 24, 2020

Thank you for the comments. Fixed

@bkamins bkamins merged commit a79ebc2 into JuliaData:master Aug 24, 2020
@bkamins bkamins deleted the improve_columnindex branch August 24, 2020 17:53
@bkamins
Copy link
Member Author

bkamins commented Aug 24, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature non-breaking The proposed change is not breaking performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

columnindex for DataFrameRow
2 participants