Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING] Make DataFrameColumns stop being an AbstractVector #2291

Merged
merged 13 commits into from
Jun 24, 2020
Merged

[BREAKING] Make DataFrameColumns stop being an AbstractVector #2291

merged 13 commits into from
Jun 24, 2020

Commits on Jun 16, 2020

  1. make DataFrameColumns stop being AbstractVector

    @bkamins
    bkamins committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    29bbddc View commit details
    Browse the repository at this point in the history

  2. add tests

    @bkamins
    bkamins committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    a994880 View commit details
    Browse the repository at this point in the history

  3. add functionality to DataFrameCols

    @bkamins
    bkamins committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    20990c8 View commit details
    Browse the repository at this point in the history

  4. update function definitions

    @bkamins
    bkamins committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    f087796 View commit details
    Browse the repository at this point in the history

  5. fix typo

    @bkamins
    bkamins committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    5ba91af View commit details
    Browse the repository at this point in the history

  6. fixes following removal of <:AbstractVector subtyping

    @bkamins
    bkamins committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    405487f View commit details
    Browse the repository at this point in the history

  7. fixes after code review

    @bkamins
    bkamins committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    b400791 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
    @bkamins @nalimilan
    bkamins and nalimilan authored Jun 21, 2020
    Configuration menu
    Copy the full SHA
    af2be96 View commit details
    Browse the repository at this point in the history

  2. improve docstrings and make a view when subsetting

    @bkamins
    bkamins committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    ce2c5be View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. fix problem with multiindex on eachcol

    @bkamins
    bkamins committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    7786867 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
    @bkamins @nalimilan
    bkamins and nalimilan authored Jun 24, 2020
    Configuration menu
    Copy the full SHA
    9192e15 View commit details
    Browse the repository at this point in the history

  2. update functionality after the discusssion

    @bkamins
    bkamins committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    7c62762 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
    @bkamins @nalimilan
    bkamins and nalimilan authored Jun 24, 2020
    Configuration menu
    Copy the full SHA
    65c969d View commit details
    Browse the repository at this point in the history