Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various docs updates #2077

Merged
merged 3 commits into from
Jan 26, 2020
Merged

Various docs updates #2077

merged 3 commits into from
Jan 26, 2020

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Jan 3, 2020

Fixes #1265

@bkamins
Copy link
Member Author

bkamins commented Jan 3, 2020

❌ is due to coverage

docs/src/man/getting_started.md Outdated Show resolved Hide resolved
│ 2 │ 3 │ 4 │
```
You can also easily convert a data frame back to a vector of `NamedTuples`.
Here we present two ways that this can be achieved, one using `Tables.rowtable`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Here we present two ways that this can be achieved, one using `Tables.rowtable`
Here we present two ways that this can be achieved, one using the `Tables.rowtable`

But I'd just stop after "achieved", as the test of the sentence merely repeats the code. :-)

Finally, isn't the first way much faster? In that case maybe not recommend the second one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first way is only 50% faster (which was a surprise to me), but it is consistently faster, so I will stick to your recommendation and drop the other way (I wanted to show the user how to use pure DataFrames.jl solution, but you are right that it is better to show good solutions).

src/abstractdataframe/abstractdataframe.jl Outdated Show resolved Hide resolved
src/abstractdataframe/abstractdataframe.jl Outdated Show resolved Hide resolved
src/abstractdataframe/sort.jl Outdated Show resolved Hide resolved
src/dataframerow/dataframerow.jl Outdated Show resolved Hide resolved
src/dataframerow/dataframerow.jl Outdated Show resolved Hide resolved
src/dataframerow/dataframerow.jl Outdated Show resolved Hide resolved
src/dataframerow/dataframerow.jl Outdated Show resolved Hide resolved
bkamins and others added 2 commits January 6, 2020 09:07
@bkamins
Copy link
Member Author

bkamins commented Jan 6, 2020

Thank you for the patience and scrutiny as always :).

@bkamins
Copy link
Member Author

bkamins commented Jan 26, 2020

@nalimilan Thank you.

@bkamins bkamins merged commit 3e09fd9 into JuliaData:master Jan 26, 2020
@bkamins bkamins deleted the docs_updates branch January 26, 2020 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functions that need docstrings
2 participants