-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various docs updates #2077
Various docs updates #2077
Conversation
❌ is due to coverage |
docs/src/man/getting_started.md
Outdated
│ 2 │ 3 │ 4 │ | ||
``` | ||
You can also easily convert a data frame back to a vector of `NamedTuples`. | ||
Here we present two ways that this can be achieved, one using `Tables.rowtable` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we present two ways that this can be achieved, one using `Tables.rowtable` | |
Here we present two ways that this can be achieved, one using the `Tables.rowtable` |
But I'd just stop after "achieved", as the test of the sentence merely repeats the code. :-)
Finally, isn't the first way much faster? In that case maybe not recommend the second one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first way is only 50% faster (which was a surprise to me), but it is consistently faster, so I will stick to your recommendation and drop the other way (I wanted to show the user how to use pure DataFrames.jl solution, but you are right that it is better to show good solutions).
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
Thank you for the patience and scrutiny as always :). |
@nalimilan Thank you. |
Fixes #1265