-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate get and haskey for AbstractDataFrame #1836
Conversation
Shouldn't we also deprecate |
This was exactly my thinking that We could rename |
Could we just deprecate |
I could do it, but the problem is that
In short - if we do it, then it should be only a temporary decision with the plan to provide a first class function that checks if some column exists in a data frame. How do you see this? |
Yes, it's much slower, but do we expect it to be used in performance-critical paths? |
Yes - I just wanted to make sure that we note down the consequences. |
I have deprecated |
I propose to deprecate
get
method forAbstractDataFrame
. I think it is not used and in general it is confusing to have it since we moved fromAbstractDict
interpretation.