Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: implementation of new setindex! and broadcasting rules #1646

Closed
wants to merge 17 commits into from
Closed

WIP: implementation of new setindex! and broadcasting rules #1646

wants to merge 17 commits into from

Commits on Apr 28, 2019

  1. initial specification of rules

    @bkamins
    bkamins committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    ecb0d2d View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-Authored-By: bkamins <bkamins@sgh.waw.pl>
    @nalimilan @bkamins
    nalimilan and bkamins committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    346d8b8 View commit details
    Browse the repository at this point in the history

  3. Incorporate review messages

    @bkamins
    bkamins committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    d1878bd View commit details
    Browse the repository at this point in the history

  4. a small additional comment

    @bkamins
    bkamins committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    a37a4e7 View commit details
    Browse the repository at this point in the history

  5. disallow a tuple on RHS of assignments and clarify what empty data fr… 

    …ame is
    @bkamins
    bkamins committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    a3d2be5 View commit details
    Browse the repository at this point in the history

  6. better df[row, cols] = v rule

    @bkamins
    bkamins committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    4c34717 View commit details
    Browse the repository at this point in the history

  7. expect vector of vectors in df[rows,cols]=v on RHS

    @bkamins
    bkamins committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    03982f0 View commit details
    Browse the repository at this point in the history

  8. re-introduce tuple of vectors

    @bkamins
    bkamins committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    c8f7f49 View commit details
    Browse the repository at this point in the history

  9. Update docs/src/lib/indexing.md 

    Co-Authored-By: bkamins <bkamins@sgh.waw.pl>
    @oxinabox @bkamins
    oxinabox and bkamins committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    9f56e86 View commit details
    Browse the repository at this point in the history

  10. improvement of description of rules

    @bkamins
    bkamins committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    7fa4896 View commit details
    Browse the repository at this point in the history

  11. improve specification of the rules

    @bkamins
    bkamins committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    36262aa View commit details
    Browse the repository at this point in the history

  12. improve description

    @bkamins
    bkamins committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    3af8490 View commit details
    Browse the repository at this point in the history

  13. first part of implementation of setindex! (WIP)

    @bkamins
    bkamins committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    f78f524 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2019

  1. Merge branch 'master' into broadcasted_assignment

    @bkamins
    bkamins committed May 4, 2019
    Configuration menu
    Copy the full SHA
    6c7985f View commit details
    Browse the repository at this point in the history

  2. additional fixes

    @bkamins
    bkamins committed May 4, 2019
    Configuration menu
    Copy the full SHA
    f41a830 View commit details
    Browse the repository at this point in the history

  3. make df[cols] = v perform a copy of passed columns

    @bkamins
    bkamins committed May 4, 2019
    Configuration menu
    Copy the full SHA
    cca9f77 View commit details
    Browse the repository at this point in the history

  4. implement temporary setindex! rules

    @bkamins
    bkamins committed May 4, 2019
    Configuration menu
    Copy the full SHA
    90855b9 View commit details
    Browse the repository at this point in the history