Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify eachcol and columns functions #1590

Merged
merged 39 commits into from
Nov 14, 2018
Merged
Changes from 2 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
4f9c61a
unify eachcol and columns
bkamins Nov 8, 2018
65a2d1e
clean up deprecated code
bkamins Nov 8, 2018
c9b8e88
add paren
bkamins Nov 8, 2018
ebc6835
add rawcolumns and fix DataFrameStream
bkamins Nov 8, 2018
97af6cc
make DFColumnIterator and DFRowIterator subtypes of AbstractArray
bkamins Nov 8, 2018
a470817
avoid using map! on columns
bkamins Nov 8, 2018
17b28a0
change eltypes
bkamins Nov 9, 2018
c3663bf
test fixes
bkamins Nov 9, 2018
5a2e30c
cleanup accessor methods
bkamins Nov 9, 2018
4da925c
fix typo
bkamins Nov 9, 2018
1cd3d3c
fix another typo
bkamins Nov 9, 2018
0fd91aa
further fix getindex of iterators
bkamins Nov 9, 2018
7f10bba
fix test
bkamins Nov 9, 2018
717f47b
qualify depwarn
bkamins Nov 9, 2018
22f2b90
final fixes
bkamins Nov 9, 2018
32f2fb2
change broadcasting to map in tests
bkamins Nov 10, 2018
4bd4f3c
further Julia 0.7 fixes
bkamins Nov 10, 2018
f8a4dab
further Julia 0.7 fixes
bkamins Nov 10, 2018
f584ffb
Wording
nalimilan Nov 10, 2018
9bda15d
Update src/abstractdataframe/iteration.jl
nalimilan Nov 11, 2018
a317e77
Update src/abstractdataframe/iteration.jl
nalimilan Nov 11, 2018
a776b64
go for AbstractVector subtyping
bkamins Nov 11, 2018
c882551
fix tests
bkamins Nov 11, 2018
4536033
fix subtyping
bkamins Nov 11, 2018
91edc19
documentation cleanup
bkamins Nov 11, 2018
f57af37
Update docs/src/lib/types.md
nalimilan Nov 11, 2018
4566656
apply review comments
bkamins Nov 11, 2018
ceb697c
Merge branch 'df_col_iteration' of https://github.com/bkamins/DataFra…
bkamins Nov 11, 2018
82aa836
revert test to a more terse form
bkamins Nov 11, 2018
52e9010
improve deprecation period
bkamins Nov 11, 2018
e42b8d3
fix typos
bkamins Nov 11, 2018
b63ccba
Update src/abstractdataframe/iteration.jl
nalimilan Nov 12, 2018
4576df6
Update src/abstractdataframe/iteration.jl
nalimilan Nov 12, 2018
213106f
fixes after a code review
bkamins Nov 12, 2018
d9c8a30
small fixes
bkamins Nov 12, 2018
e1cb969
fix collect signature
bkamins Nov 12, 2018
912f1b4
Merge branch 'master' into df_col_iteration
bkamins Nov 13, 2018
2363ef5
add mapcols tests
bkamins Nov 13, 2018
6d1eb90
allow @inbounds and re-enable some tests
bkamins Nov 13, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/src/lib/types.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ The difference between the return value of `eachcol` and `columns` is the follow
* The `columns` function returns a value of the `DataFrameColumns{<:AbstractDataFrame, false}` type, which is an
iterator returning the column vector only.

The `DataFrameRows` and `DataFrameColumns` types are subtypes of `AbstractVector` and support its interface
The `DFRowVector` and `DFColumnVector` types are subtypes of `AbstractVector` and support its interface
with the exception that they are read only. Note that they are not exported and should not be constructed directly,
but using `eachrow`, `eachcol` and `columns` functions.
but using the `eachrow`, `eachcol` and `columns` functions.

## Types specification

Expand Down