-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
why #618
Comments
Dup of #617. |
The idea is that in the future it will (likely) be possible to use the Anyway, for column names like "Return standard deviation", I think column labels will be more useful (#35). |
I agree with Milan: column labels are more useful than allowing names that aren't valid identifiers. |
The argument isn't that it's useful to have column names with spaces (or otherwise not valid identifiers), but that preventing them when when the user explicitly asks for them is annoying and unnecessary. |
As I said in #617, if the ability to do this exists, someone is going to do this in library code. Then you'll get broken names when you didn't ask for them. If this really matters, we can change this restriction. But the absence of this restriction infuriates me when using R. |
How about an optional named argument “allownonidentifiers”? From: John Myles White [mailto:notifications@github.com] As I said in #617#617, if the ability to do this exists, someone is going to do this in library code. Then you'll get broken names when you didn't ask for them. If this really matters, we can change this restriction. But the absence of this restriction infuriates me when using R. — |
I would rather either allow this or not, rather than add in a keyword argument. |
My position is that DataFrames should carefully avoid generating column names that aren't valid identifiers, to make the default experience as smooth as possible, but should make no assumptions about the column names and accept any symbols, valid identifiers or not, as names. |
Just to be clear: the experience is never going to be completely smooth when you use a symbol that's not an identifier, because that symbol won't parse correctly in things like formulas. But I'll stick to the deal proposed in #617. |
Closing as a dup of #617. |
Perhaps this is more of a question than an issue. Why does DataFrames now disallow column names which are not valid identifiers? The column name is a visual label for the column. If I want it to be "Return standard deviation", I think it should be allowed.
The text was updated successfully, but these errors were encountered: