-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataFrames should be indexable by CartesianIndex{2}
#1610
Comments
I guess that would be consistent, but in what situations would it be useful? |
It's just a standard way to iterate over things. I for one use it more and more. It's already column major so it's a good way to iterate. If you ever are iterating over a matrix and a dataframe at the same time, it might be useful. I'd be happy to make the PR, when I get to it. |
Iterating over a data frame and a matrix at the same time is unlikely to be a good idea given how slow it's going to be compared to iterating over columns... |
Well, they are both column major so if you have to iterate over the dataframe anyway I don't really see what harm it would do (other than typing issues of course). Regardless, is there some reason you are opposed to making dataframes indexable by |
Well the type-instability issue is a big problem in terms of performance. I'm not really opposed to supporting cartesian indexing, I'm just not sure it's really useful. |
I think it is not a problem to have it for |
We now allow |
(we do not provide |
It should be possible to do, for example
The text was updated successfully, but these errors were encountered: