Overload Compat.eachrow and Compat.eachcol (#2067)

JuliaData · Dec 27, 2019 · baf2740 · baf2740
1 parent 7b1ab38
commit baf2740
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/Project.toml b/Project.toml
@@ -34,7 +34,7 @@ test = ["DataStructures", "DataValues", "Dates", "Logging", "Random", "Test"]
 [compat]
 julia = "1"
 CategoricalArrays = "0.7"
-Compat = "2, 3"
+Compat = "2.2, 3"
 DataAPI = "1.0.1"
 InvertedIndices = "1"
 IteratorInterfaceExtensions = "0.1.1, 1"

diff --git a/src/DataFrames.jl b/src/DataFrames.jl
@@ -53,6 +53,7 @@ export AbstractDataFrame,
 if VERSION >= v"1.1.0-DEV.792"
     import Base.eachcol, Base.eachrow
 else
+    import Compat.eachcol, Compat.eachrow
     export eachcol, eachrow
 end
 

diff --git a/test/iteration.jl b/test/iteration.jl
@@ -1,5 +1,6 @@
 module TestIteration
 
+import Compat
 using Test, DataFrames
 
 df = DataFrame(A = Vector{Union{Int, Missing}}(1:2), B = Vector{Union{Int, Missing}}(2:3))
@@ -140,4 +141,10 @@ end
     end
 end
 
+@testset "overload Compat functions" begin
+    @testset "DataFrames.$f === Compat.$f" for f in intersect(names(DataFrames), names(Compat))
+        @test getproperty(DataFrames, f) === getproperty(Compat, f)
+    end
+end
+
 end # module