Add droplevels! function for removing unused pool values #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkamins
reviewed
Nov 22, 2020
|
|
||
| For an array `A` that implements [`levels`](@ref DataAPI.levels)), certain levels may | ||
| become "unused" via array modification, meaning the values still exist in the array | ||
| "pool", but are no longer present in the actual array values. `droplevels!` remove |
There was a problem hiding this comment.
maybe add a reference to refpool explicitly rather than "pool"?
bkamins
reviewed
Nov 22, 2020
| "pool", but are no longer present in the actual array values. `droplevels!` remove | ||
| such values to ensure `levels` only returns values that currently exist in the array. | ||
|
|
||
| This generic function is owned by DataAPI.jl itself, which is the sole provider of the |
There was a problem hiding this comment.
in CategoricalArrays.jl droplevels! returns A. @nalimilan probably can comment better here about the design assumptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.