Fix allocations by dropping CategoricalPool type parameter
#418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Self-referential types generate allocations since Julia 1.11 (JuliaLang/julia#58169). This third parameter seems to have been unnecessary since `NominalValue` and `OrdinalValue` got merged into a single `CategoricalValue` type.
Member
|
I think this simplification is beneficial in general. We should just warn in the release that the deserialization is not backward compatible. |
bkamins
approved these changes
Apr 28, 2025
Member
bkamins
left a comment
bkamins
left a comment
There was a problem hiding this comment.
Just maybe add NEWS.jl or something similar so that users are aware of the change.
Member
Author
|
You mean in the 1.0 release or the 0.10.x one? We don't have NEWS but I'll definitely add release notes when tagging. |
Member
Author
|
Merging anyway before #358 so that backporting remains possible without creating a dedicated branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-referential types generate allocations since Julia 1.11 (JuliaLang/julia#58169). This third parameter seems to have been unnecessary since
NominalValueandOrdinalValuegot merged into a singleCategoricalValuetype.Fixes #412.
I'm not sure we should backport this or not, given that it's slightly breaking (in particular it breaks deserializing old objects). I don't see a way to fix this without changing type parameters -- the other option is to add one parameter to
CategoricalValue.