Skip to content

Commit

Permalink
Fix tests on Julia 1.9 nightlies (#385)
Browse files Browse the repository at this point in the history
A recent change on Julia master (JuliaLang/julia#44096) makes an array
of arrays use more precise promotion, which ends up converting
`CategoricalArray`s into `Vector`s.
  • Loading branch information
nalimilan authored Mar 13, 2022
1 parent f79f8cc commit 4d7e344
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/13_arraycommon.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1952,11 +1952,11 @@ end

@testset "repeat" begin
for o in (false, true), c in (false, true), i in 0:2,
a in [["b", "a", "b"], ["b" "a"; "b" "c"],
[missing, "a", "b"], ["b" "a"; missing "c"]],
x in [categorical(a, ordered=o, compress=c),
a in (["b", "a", "b"], ["b" "a"; "b" "c"],
[missing, "a", "b"], ["b" "a"; missing "c"]),
x in (categorical(a, ordered=o, compress=c),
view(categorical(a, ordered=o, compress=c), axes(a)...),
view(categorical([a a], ordered=o, compress=c), axes(a)...)]
view(categorical([a a], ordered=o, compress=c), axes(a)...))
xr = @inferred repeat(x, i)
@test which(repeat, (typeof(x), Int)).module == CategoricalArrays
@test typeof(parent(x)) == typeof(xr)
Expand Down

2 comments on commit 4d7e344

@nalimilan
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/56513

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.10.4 -m "<description of version>" 4d7e344650717997a6fa0c9fe9012b8c9a8630c3
git push origin v0.10.4

Please sign in to comment.