Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataFrame(CSV.File(...)) with header-only #703

Closed
wants to merge 2 commits into from
Closed

Conversation

omus
Copy link
Member

@omus omus commented Jul 31, 2020

Fixes #702. Reverts part of #687

@omus
Copy link
Member Author

omus commented Aug 1, 2020

Was failing due to: JuliaData/SentinelArrays.jl#22. Restarting CI

@omus omus closed this Aug 1, 2020
@omus omus reopened this Aug 1, 2020
@omus
Copy link
Member Author

omus commented Aug 1, 2020

Rebased and resolved conflicts

@omus
Copy link
Member Author

omus commented Aug 1, 2020

I just noticed the alternative DataFrames fix. I do prefer that fix. I'll close this after the CI finishes

@codecov
Copy link

codecov bot commented Aug 1, 2020

Codecov Report

Merging #703 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #703   +/-   ##
=======================================
  Coverage   84.81%   84.81%           
=======================================
  Files          10       10           
  Lines        1850     1851    +1     
=======================================
+ Hits         1569     1570    +1     
  Misses        281      281           
Impacted Files Coverage Δ
src/CSV.jl 33.33% <100.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f93473f...2d133e1. Read the comment docs.

@omus
Copy link
Member Author

omus commented Aug 2, 2020

Closing in favor of JuliaData/DataFrames.jl#2341

@omus omus closed this Aug 2, 2020
@omus omus deleted the cv/header-only-fix branch August 2, 2020 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFrame(CSV.File(...)) broken with header-only
1 participant