Skip to content

Conversation

@kragol
Copy link
Contributor

@kragol kragol commented Jul 8, 2020

I realize there is a rather severe performance issue with this option. Was it left undocumented on purpose?

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #682 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
- Coverage   84.47%   84.42%   -0.05%     
==========================================
  Files          10       10              
  Lines        1778     1779       +1     
==========================================
  Hits         1502     1502              
- Misses        276      277       +1     
Impacted Files Coverage Δ
src/file.jl 96.30% <ø> (ø)
src/utils.jl 81.64% <0.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 131f233...b96868a. Read the comment docs.

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@quinnj quinnj merged commit d4ce5b6 into JuliaData:master Jul 9, 2020
quinnj added a commit that referenced this pull request Jan 12, 2026
added documentation for the dateformats option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants