You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes#679
This may not be the cleanest fix but it seems to work. I guess it can be fine for now since the whole parsing is apparently in the process of being rewritten.
Note: I am a Julia beginner so any feedback is appreciated.
Fixes#679; alternative fix to #681. When a column is dropped, we
essentially turn it into a `Missing` column type and ignore it when
parsing. There was a check later in file parsing, however, that said if
no missing values were found in a column, to ensure its type is
`Vector{T}` instead of `Vector{Union{Missing, T}}`. The core problem in
issue #679 was that these dropped columns, while completely `missing`,
didn't get "flagged" as having `missing` values.
Thanks for reporting the issue @kragol! And proposing a fix! While this fix is fine, there's actually a slightly simpler fix that I've put up in #683. We have a flags array that carries various bit flags that get/set properties for columns, one of which is if anymissing values were parsed. So my alternative fix is to just make sure when a column is marked as WILLDROP, we also mark ANYMISSING since the entire column will be treated as missing values.
Fixes#679; alternative fix to #681. When a column is dropped, we
essentially turn it into a `Missing` column type and ignore it when
parsing. There was a check later in file parsing, however, that said if
no missing values were found in a column, to ensure its type is
`Vector{T}` instead of `Vector{Union{Missing, T}}`. The core problem in
issue #679 was that these dropped columns, while completely `missing`,
didn't get "flagged" as having `missing` values.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #679
This may not be the cleanest fix but it seems to work. I guess it can be fine for now since the whole parsing is apparently in the process of being rewritten.
Note: I am a Julia beginner so any feedback is appreciated.