Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFTW and DSP collision over Periodograms #320

Closed
caseykneale opened this issue Nov 9, 2019 · 2 comments · Fixed by JuliaRegistries/General#5230 or #322
Closed

FFTW and DSP collision over Periodograms #320

caseykneale opened this issue Nov 9, 2019 · 2 comments · Fixed by JuliaRegistries/General#5230 or #322

Comments

@caseykneale
Copy link

Tried to build my package today only to find it was broken by some dependencies.

[ Info: Precompiling ChemometricsTools [a9718f02-dbee-5ae5-ad0e-dfbd07fa387b]
WARNING: both FFTW and Util export "Frequencies"; uses of it in module Periodograms must be qualified
ERROR: LoadError: LoadError: UndefVarError: Frequencies not defined
Stacktrace:
 [1] top-level scope at none:0
 [2] include at ./boot.jl:317 [inlined]
 [3] include_relative(::Module, ::String) at ./loading.jl:1044
 [4] include at ./sysimg.jl:29 [inlined]
 [5] include(::String) at /home/caseykneale/.julia/packages/DSP/wwKNu/src/DSP.jl:1
 [6] top-level scope at none:0
 [7] top-level scope at none:2
in expression starting at /home/caseykneale/.julia/packages/DSP/wwKNu/src/periodograms.jl:186
in expression starting at /home/caseykneale/.julia/packages/DSP/wwKNu/src/DSP.jl:13
ERROR: LoadError: LoadError: Failed to precompile DSP [717857b8-e6f2-59f4-9121-6e50c889abd2] to /home/caseykneale/.julia/compiled/v1.0/DSP/OtML7.ji.
Stacktrace:
 [1] include at ./boot.jl:317 [inlined]
 [2] include_relative(::Module, ::String) at ./loading.jl:1044
 [3] include at ./sysimg.jl:29 [inlined]
 [4] include(::String) at /home/caseykneale/Desktop/ChemometricsTools/ChemometricsTools.jl/src/ChemometricsTools.jl:1
 [5] top-level scope at none:0
 [6] top-level scope at none:2
in expression starting at /home/caseykneale/Desktop/ChemometricsTools/ChemometricsTools.jl/src/Preprocess.jl:1
in expression starting at /home/caseykneale/Desktop/ChemometricsTools/ChemometricsTools.jl/src/ChemometricsTools.jl:56
@dlfivefifty dlfivefifty mentioned this issue Nov 9, 2019
Merged
kahaaga added a commit to JuliaDynamics/TimeseriesSurrogates.jl that referenced this issue Nov 9, 2019
@kahaaga
Add upper bounds to AbstractFFts.
eff9353 
This fixes error due to import conflicts between DSP and FFTW (ref JuliaDSP/DSP.jl#320)
This was referenced Nov 9, 2019
Closed
Merged
@hjkim1304
Copy link

Sorry, but I'm getting the same issue, is there anything I should be doing? I tried updating and downloading TimeseriesSurrogates as well, but the issue persists. Any help would be greatly appreciated.

@caseykneale
Copy link
Author

I think it's something the DSP.jl developers need to fix.

For my package I was only using DSP for 1D Convolutions. So I removed the dependency(for now) and wrote my 10min version of it.

@ararslan ararslan mentioned this issue Nov 10, 2019
Merged
@DhairyaLGandhi DhairyaLGandhi mentioned this issue Nov 12, 2019
Closed
@mfalt mfalt mentioned this issue Nov 12, 2019
Merged
galenlynch added a commit to galenlynch/General that referenced this issue Nov 23, 2019
@galenlynch
Add upper bounds to FFTW and DSP Compats
9fc45de 
This is another attempt at JuliaRegistries#5230, which was an attempt at fixing the breakage
caused by JuliaMath/AbstractFFTs.jl#26 (e.g. JuliaDSP/DSP.jl#320,
JuliaDSP/DSP.jl#323, JuliaDSP/DSP.jl#324). The underlying problem is that
JuliaMath/AbstractFFTs.jl#26 moved functions from DSP.jl to AbstractFFTs.jl,
requiring users to have versions of both of those packages either before that
change or after it. Because FFTW reexports AbstractFFTWs, users also have to
coordinate versions of DSP.jl and FFTW.jl.

This problem was fixed for the most recent versions of DSP.jl and
FFTW.jl (v0.6.1 and v1.1, respectively) by JuliaDSP/DSP.jl#322 and
JuliaMath/FFTW.jl#124. However, because earlier versions of FFTW do not have an
upper bound for its dependency on AbstractFFTs, and neither does DSP, Pkg cannot
currently tell that some combinations of versions for AsbtractFFTs and DSP.jl
are incompatible, which is causing users to experience issues even after the
problem was fixed for the most recent versions (JuliaDSP/DSP.jl#323,
JuliaDSP/DSP.jl#324).

Fixing the problem is made slightly more complicated because DSP does not
explicitly depend on AbstractFFTs, but instead DSP implicitly depends on
AbstractFFTs through FFTW's reexport of it, and in turn DSP explicitly depends
on FFTW.

To fix this problem, I have changed the Compat.toml for FFTW to place a upper
bound on AbstractFFTs, so that packages get a consistent interface when using
FFTW. I have also changed the Compat.toml for DSP, to avoid breakage caused by
AbstractFFTs v0.5 taking some functions that were previously defined in DSP.

In addition, the Compat.toml for DSP showed versions before 0.5.1 to be
compatible with Julia 1, which was inaccurate. I have therefore changed this
TOML table to restrict the DSP versions to the range that is compatible with
Julia 1.

I have tested that these changes work for the most recent versions of DSP and
FFTW, as well as older versions.
@galenlynch galenlynch mentioned this issue Nov 23, 2019
Merged
ararslan pushed a commit to JuliaRegistries/General that referenced this issue Nov 25, 2019
@galenlynch @ararslan
Add upper bounds to FFTW and DSP Compats (#5778)
69fd35e 
This is another attempt at #5230, which was an attempt at fixing the breakage
caused by JuliaMath/AbstractFFTs.jl#26 (e.g. JuliaDSP/DSP.jl#320,
JuliaDSP/DSP.jl#323, JuliaDSP/DSP.jl#324). The underlying problem is that
JuliaMath/AbstractFFTs.jl#26 moved functions from DSP.jl to AbstractFFTs.jl,
requiring users to have versions of both of those packages either before that
change or after it. Because FFTW reexports AbstractFFTWs, users also have to
coordinate versions of DSP.jl and FFTW.jl.

This problem was fixed for the most recent versions of DSP.jl and
FFTW.jl (v0.6.1 and v1.1, respectively) by JuliaDSP/DSP.jl#322 and
JuliaMath/FFTW.jl#124. However, because earlier versions of FFTW do not have an
upper bound for its dependency on AbstractFFTs, and neither does DSP, Pkg cannot
currently tell that some combinations of versions for AsbtractFFTs and DSP.jl
are incompatible, which is causing users to experience issues even after the
problem was fixed for the most recent versions (JuliaDSP/DSP.jl#323,
JuliaDSP/DSP.jl#324).

Fixing the problem is made slightly more complicated because DSP does not
explicitly depend on AbstractFFTs, but instead DSP implicitly depends on
AbstractFFTs through FFTW's reexport of it, and in turn DSP explicitly depends
on FFTW.

To fix this problem, I have changed the Compat.toml for FFTW to place a upper
bound on AbstractFFTs, so that packages get a consistent interface when using
FFTW. I have also changed the Compat.toml for DSP, to avoid breakage caused by
AbstractFFTs v0.5 taking some functions that were previously defined in DSP.

In addition, the Compat.toml for DSP showed versions before 0.5.1 to be
compatible with Julia 1, which was inaccurate. I have therefore changed this
TOML table to restrict the DSP versions to the range that is compatible with
Julia 1.

I have tested that these changes work for the most recent versions of DSP and
FFTW, as well as older versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add upper bounds to DSP.jl dlfivefifty/General
Accommodate AbstractFFTs PR 26 JuliaDSP/DSP.jl
2 participants
@hjkim1304 @caseykneale