Fix nightly tests #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.5 is the lowest version we support here.
|
Bisect shows that it was JuliaLang/julia#46068 that caused the tests to start failing. |
pfitzseb
approved these changes
Oct 31, 2022
mortenpi
added a commit
that referenced
this pull request
Oct 31, 2022
* Use Pkg.develop instead of LOAD_PATH * Expand CI test matrix to include 1.5, 1.7 1.5 is the lowest version we support here. (cherry picked from commit ad3c9a9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I don't quite understand what has changed and why pushing to
LOAD_PATHdoesn't work any more on nightly, but usingPkg.developseems fix it.The issue seems to be that when you try to load
DummyStorageBackendsviaLOAD_PATH, it looks for its DataSets dependency in the depo, rather than realizing that it's already loaded intoMain. To repro locally, it may be necessary to have a clean depot.