-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlobTree API refactor including newfile() / newdir(), and renaming. #45
Merged
Commits on May 16, 2022
-
Big BlobTree API refactor including newfile() / newdir()
Refactor newfile() / newdir() into primarily in-place APIs. A temporary directory can still be created with newdir(). Before this refactor the API looked slightly nicer, but we would never be able to reach the efficiency of the native file APIs. In particular, we might end up moving data across devices as a last step in constructing a directory tree — this seemed bad! Various changes to BlobTree API to make it more Dict-like and less reliant on overloading filesystem-like functions. * Further document the BlobTree API * Allow path strings as keys in more places in BlobTree * Deprecations of some filesystem-like functions
Configuration menu - View commit details
-
Copy full SHA for 7ffc2d2 - Browse repository at this point
Copy the full SHA 7ffc2d2View commit details -
Rename Blob->File, BlobTree->FileTree
* The big rename * Add deprecations for Blob, BlobTree
Configuration menu - View commit details
-
Copy full SHA for 75010a3 - Browse repository at this point
Copy the full SHA 75010a3View commit details -
Not including documentation on writing to a file tree yet; that will come in a future change.
Configuration menu - View commit details
-
Copy full SHA for 0523441 - Browse repository at this point
Copy the full SHA 0523441View commit details
Commits on May 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 49b14d9 - Browse repository at this point
Copy the full SHA 49b14d9View commit details
Commits on May 18, 2022
-
WIP: Improved test coverage for FileTree / File
Also some docstring refinement
Configuration menu - View commit details
-
Copy full SHA for 311ead2 - Browse repository at this point
Copy the full SHA 311ead2View commit details
Commits on May 19, 2022
-
Tests + simplify FileSystemRoot
* Additional tests for FileTree - the whole API should be covered now. * Remove internal TempFilesystemRoot; replace with a simple flag on FileSystemRoot. * Remove internal AbstractFileSystemRoot; this seems unnecessary now.
Configuration menu - View commit details
-
Copy full SHA for 4c7480e - Browse repository at this point
Copy the full SHA 4c7480eView commit details
Commits on May 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for bb0e6e3 - Browse repository at this point
Copy the full SHA bb0e6e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6505b4 - Browse repository at this point
Copy the full SHA a6505b4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.