Repository navigation
bugfix: make setindex! on PriorityQueue return collection - #829
Merged
Merged
Conversation
To follow the abstract dictionary API, `setindex!` shall return the priority queue when applied to such objects. This also fixes pushing of multiple items with `push!`.
nsajko
changed the title
setindex! on PriorityQueue return collection instead of value
nsajko
approved these changes
Oct 9, 2026
nsajko
changed the title
setindex! on PriorityQueue return collection instead of valuesetindex! on PriorityQueue return collection instead of elem
nsajko
changed the title
setindex! on PriorityQueue return collection instead of elemsetindex! on PriorityQueue return collection
nsajko
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To follow the abstract dictionary API,
setindex!shall return the priority queue when applied to such objects. This also fixes pushing of multiple items withpush!on a priority queue.