@inline binary heap top call

[ChrisRackauckas]

This will allow @inbounds to propagate into this call.

[yuyichao]

is this function too large to be automatically inlined?

[ChrisRackauckas]

In profiling I found this to be a surprisingly expensive operation, so I assumed this must be part of it. I'll see if I can find out more directly.

(But I also thought that inline-ing will only let @inbounds through if you @inline)

[codecov]

Codecov Report

Merging #292 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #292      +/-   ##
=========================================
+ Coverage    95.9%   95.9%   +<.01%     
=========================================
  Files          31      31              
  Lines        2244    2245       +1     
=========================================
+ Hits         2152    2153       +1     
  Misses         92      92

Impacted Files	Coverage Δ
src/heaps/mutable_binary_heap.jl	92.66% <100%> (ø)	⬆️
src/heaps/binary_heap.jl	100% <100%> (ø)	⬆️
src/priorityqueue.jl	88.76% <0%> (+0.12%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 161792b...8478bfb. Read the comment docs.

[oxinabox]

The inlining properation rules are a bit complex (for good reasons).
https://docs.julialang.org/en/latest/devdocs/boundscheck/

AFAICT @ChrisRackauckas is generally right, though there might be a better way (eg with @propergate_inbounds).
But in general a lot of the code needs an audit over its use of @inline as a lot was written for versions of julia with marginally (or significantly) different inlining rules.