Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated doc for construction of PriorityQueue #340

Closed
s-celles opened this issue Nov 8, 2017 · 0 comments
Closed

Deprecated doc for construction of PriorityQueue #340

s-celles opened this issue Nov 8, 2017 · 0 comments

Comments

@s-celles
Copy link
Member

s-celles commented Nov 8, 2017

Hello,

according doc https://github.com/JuliaCollections/DataStructures.jl/blame/4cd14487c7f66f4e2a61d0e703b06b3a6a660a4e/doc/source/priority-queue.rst#L12
and docstring

PriorityQueue(K, V, [ord])

construction of a PriorityQueue could be done using PriorityQueue(K, V) where K and V are types of keys and priorities but it raises a warning

julia> PriorityQueue(Int, String)
WARNING: PriorityQueue{K, V}(::Type{K}, ::Type{V}) is deprecated, use PriorityQueue{K, V}() instead.
Stacktrace:
 [1] depwarn(::String, ::Symbol) at ./deprecated.jl:70
 [2] DataStructures.PriorityQueue(::Type{Int64}, ::Type{String}) at ./deprecated.jl:57
 [3] eval(::Module, ::Any) at ./boot.jl:235
 [4] eval_user_input(::Any, ::Base.REPL.REPLBackend) at ./REPL.jl:66
 [5] macro expansion at ./REPL.jl:97 [inlined]
 [6] (::Base.REPL.##1#2{Base.REPL.REPLBackend})() at ./event.jl:73
while loading no file, in expression starting on line 0
DataStructures.PriorityQueue{Int64,String,Base.Order.ForwardOrdering} with 0 entries

Maybe it should be updated.

Thanks for the nice work

Kind regards

s-celles pushed a commit to s-celles/DataStructures.jl that referenced this issue Jul 29, 2018
ararslan pushed a commit that referenced this issue Jul 30, 2018
* Update priority-queue.md

Closes #340

* Update priorityqueue.jl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant