for better inferred effects, avoid relying on `reshape(::Array, ::Vararg)`?

[nsajko]

Either that or fix the effects upstream. The effects infer horribly:

julia> Base.infer_effects(reshape, Tuple{Vector{Float32}, Tuple{Int}})
(!c,!e,!n,!t,!s,!m,!u,+o,!r)

julia> Base.infer_effects(reshape, Tuple{Vector{Float32}, Tuple{Int, Colon}})
(!c,!e,!n,!t,!s,!m,!u,!o,!r)

julia> Base.infer_effects(reshape, Tuple{Vector{Float32}, Tuple{Colon, Int}})
(!c,!e,!n,!t,!s,!m,!u,!o,!r)

Even constprop doesn't seem to be able to help:

julia> Base.infer_effects((x -> reshape(x, (3,))), Tuple{Vector{Float32}})
(!c,!e,!n,!t,!s,!m,!u,+o,!r)

julia> Base.infer_effects((x -> reshape(x, (3, :))), Tuple{Vector{Float32}})
(!c,!e,!n,!t,!s,!m,!u,!o,!r)

julia> Base.infer_effects((x -> reshape(x, (:, 3))), Tuple{Vector{Float32}})
(!c,!e,!n,!t,!s,!m,!u,!o,!r)

[nsajko]

fix the effects upstream

JuliaLang/julia#58672

EDIT: now merged to v1.13, and will presumably be backported to v1.12