Stop tuning when benchmark is deemed slow enough - #429
Open
KristofferC wants to merge 1 commit into
Open
Conversation
`lineartrial` normally tests every evaluation count from 1 through `RESOLUTION`. This makes tuning unnecessarily expensive for slow benchmarks, even though they will use one evaluation per sample. Once three samples all take longer than `RESOLUTION`, further samples cannot change the result from `guessevals`. Stop the trial at that point while preserving the existing behavior for faster benchmarks. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
KristofferC
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to deal with tuning taking a silly long time for some functions (it took like 5s to tune a ~10us function to decide it should run with 3 evals and then the actual benchmark finishes very quickly) This seems like one obvious way to speed it up:
🤖 :
lineartrialnormally tests every evaluation count from 1 throughRESOLUTION. This makes tuning unnecessarily expensive for slowbenchmarks, even though they will use one evaluation per sample.
Once three samples all take longer than
RESOLUTION, further samplescannot change the result from
guessevals. Stop the trial at that pointwhile preserving the existing behavior for faster benchmarks.