Closed
Conversation
Also test if builds get cancelled on new commit.
Contributor
Author
|
Closed after discussion on slack that Buildkite doesn't have many runners and so this is going to slow down CI a fair bit. I've switched to only running buildkite CI on release julia and disabling the perf tests on Github actions in the linuxperf pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the LinuxPerf pr, to run tests with perf we need to use the Buildkite CI instead of github's.
I've split this change out from that pr.
For some reason pushing a new commit, doesn't cancel the old build. I think someone with access to the buildkite needs to fix that. Also, some parallelism would be nice.
The code coverage key needs to be provided as well.
Buildkite CI doesn't seem to support Julia 1.0, so we want to merge in #366 before this.