Conversation
jrevels
referenced
this pull request
in JuliaLang/julia
Feb 7, 2017
…0461) make fftshift and ifftshift take iterables as dimension arguments
Contributor
|
ready now? |
Member
Author
|
restarted the v0.6 builds on Travis, let's see if it passes now |
Member
Author
|
The failure looks like a parallel-related failure, and doesn't seem to be benchmark-related, so I'm gonna consider this good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires JuliaCI/BenchmarkTools.jl#43 and a subsequent BenchmarkTools v0.0.7 tag.
I'm going to try to do a tuning run on master with BenchmarkTools v0.0.7 before merging this.Tuning complete, hopefully tests will pass now.ref JuliaCI/Nanosoldier.jl#28