Remove dependence on partial linear indexing #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to test performance of JuliaLang/julia#21750.
|
Looks like I'll need to also update Compat... |
|
This is now awaiting JuliaLang/Compat.jl#399. |
|
You can bump Compat to 0.31.0 once JuliaLang/METADATA.jl#10949 is merged. |
|
I've bumped the Compat dependency for you, but this will now need #107 in order to pass CI. |
|
I'm retuning the Nanosoldier benchmarks now, and I'll trigger a new Nanosoldier run on your PR once that's done. |
Keno
pushed a commit
that referenced
this pull request
Feb 4, 2022
* update ind(min|max) to arg(min|max) * update uninitialized to undef * fix using A.B deprecation warning for non-modules * use Compat instead of VERSION-dancing * contains(haystack, needle) -> occursin(needle, haystack) * STDERR -> stderr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to test performance of JuliaLang/julia#21750.