Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a more convenient FITSHeader constructor #199

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

aplavin
Copy link
Contributor

@aplavin aplavin commented Jul 29, 2024

It's more convenient to provide all three (keys + values + comments) as a single array than separately.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.35%. Comparing base (d267f48) to head (d3e6188).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   91.30%   91.35%   +0.05%     
==========================================
  Files           5        5              
  Lines         690      694       +4     
==========================================
+ Hits          630      634       +4     
  Misses         60       60              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aplavin
Copy link
Contributor Author

aplavin commented Jul 30, 2024

Nightly failures unrelated

@aplavin
Copy link
Contributor Author

aplavin commented Aug 16, 2024

bump... any issues with it?

@giordano giordano merged commit 6d4a051 into JuliaAstro:master Aug 16, 2024
9 of 12 checks passed
@aplavin aplavin deleted the patch-2 branch August 22, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants