plot recipe for wcs info. integration #16
Conversation
aquatiko
changed the title
|
Results on IJulia: I will be adding tests shortly. |
aquatiko
changed the title
|
@giordano This PR is complete and ready to be reviewed. |
|
Merge only after #19 |
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
+ Coverage 94.91% 96.77% +1.85%
==========================================
Files 3 3
Lines 59 93 +34
==========================================
+ Hits 56 90 +34
Misses 3 3
Continue to review full report at Codecov.
|
REQUIRE
Outdated
| @@ -0,0 +1,8 @@ | |||
| julia 1 | |||
There was a problem hiding this comment.
We don't want this file back 🙂
There was a problem hiding this comment.
Fixed! It got in while merging things as this was an older branch.
|
What happens if a file doesn't have the required WCS information? |
|
Can't happen as the two keys |
|
I think other keys are used by |
| @@ -17,3 +17,60 @@ end | |||
| color := :grays | |||
| img.data[1] | |||
| end | |||
|
|
|||
| @recipe function f(img::AstroImage, wcs::WCSTransform) | |||
There was a problem hiding this comment.
I think that this recipe applies only to a single colour image (AstroImg{T,C,1}), what do you think?
My understanding is that |
| @test pix2world_xformatter(255, wcs2) == 255.0 | ||
|
|
||
| @test pix2world_yformatter(255, wcs1) == "13.98°" | ||
| @test pix2world_yformatter(255, wcs2) == 255.0 |
There was a problem hiding this comment.
Yeah, pix_to_world returns the same array for any of the types it does not recognize or doesn't have.
As tested here.
|
@giordano Do this need some fixing or is this good to be merged now? |
Added recipe for showing
xlabelandylabelfrom WCS header. Also, pixel coordinates will be displayed as world coordinates by giving a WCS asplot(img, WCS).