-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could the definition of similar_type
move here?
#3
Comments
Yes, that's reasonable. |
I guess you also need the |
but I don't know if that's common. I worked around any Size issues like https://github.com/SciML/LabelledArrays.jl/pull/122/files#diff-918dda16160ab68d9766c22082a5c3463aef402c63fdf25244313c9f2bde525eR162 |
OK, so #5 is enough? |
This would be useful for ForwardDiff as well, it seems, as it uses |
@ChrisRackauckas looks like you still need the function StaticArrays.similar_type(::Type{SLArray{S, T, N, L, Syms}}, ::Type{NewElType},
::Size{NewSize}) where {S, T, N, L, Syms, NewElType, # used here
NewSize} |
It can be worked around. |
Do you mean function StaticArrays.similar_type(::Type{SLArray{S, T, N, L, Syms}}, ::Type{NewElType}, sz) where {S, T, N, L, Syms, NewElType} ? similar_type(::Type{A}, ::Type{T}, s::Size{S}) where {A<:AbstractArray, T, S} |
SciML/LabelledArrays.jl#122
It really should be in Base, but 🤷
The text was updated successfully, but these errors were encountered: