Skip to content

general updates #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

markmbaum
Copy link
Contributor

@markmbaum markmbaum commented Mar 7, 2024

I happened to be looking for some kind of frozen/immutable/read-only array wrapper on the same day as the discussion in #8 started.

Because @bkamins says the package hasn't been maintained, I made a bunch of changes. The module source is nearly identical, but I updated the tests, readme, and dependencies.

  • I consolidated and reorganized the tests. Was there a particular reason for testing with sparse arrays? I considered it, then removed the sparse array testing. It seemed oddly specific if the module covers any AbstractArray.
  • I updated the readme to explain the module more and give an example.
  • I reformated the source module.
  • The automatic tests are now in a GitHub action, which runs automatically on all pushes (happy to change this). I removed the other coverage and build status checks.

@bkamins bkamins merged commit cf3928d into JuliaArrays:master Mar 7, 2024
@bkamins
Copy link
Collaborator

bkamins commented Mar 7, 2024

Thank you! Do you want me to bump version and tag a release?

@markmbaum
Copy link
Contributor Author

Yes, please! Although it looks like version 0.2.0 is not registered yet: https://juliahub.com/ui/Packages/General/ReadOnlyArrays

It should be sufficient to trigger a release.

@MilesCranmer
Copy link
Contributor

MilesCranmer commented Mar 20, 2024

Could you please make a new release @bkamins? Would love to use this (just found it).

Edit: wait, pause for the issue I found in #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants