Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test OffsetArray sums using Integer-valued parents #358

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Aug 18, 2024

There are some non-deterministic test failures related to floating-point precision in summing over OffsetArrays, perhaps arising from simd on some platforms. These tests do not require floating-point arrays, so we may use integer ones instead and ensure that the values are exactly comparable.

Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (3b94d64) to head (2f1e8ad).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files           6        6           
  Lines         453      453           
=======================================
  Hits          447      447           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit c0bf404 into master Aug 18, 2024
27 of 30 checks passed
@jishnub jishnub deleted the jishnub/sum_test branch August 18, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant