Skip to content

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Dec 2, 2024

Since v1.10 is the LTS now, we may focus development only on v1.10+. Versions of this pacakge <v1.15 would continue to be compatible with julia v1.6.

@codecov
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.48%. Comparing base (6f61dc3) to head (173acaf).
⚠️ Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
- Coverage   99.91%   99.48%   -0.44%     
==========================================
  Files           8        8              
  Lines        1147     1154       +7     
==========================================
+ Hits         1146     1148       +2     
- Misses          1        6       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@devmotion
Copy link
Contributor

I think it would be a good opportunity to also clean up existing VERSION checks in the package and the tests.

@devmotion
Copy link
Contributor

devmotion commented Oct 2, 2025

It actually seems that Julia < 1.10.10 is completely untested at this point:

version:
- 'lts'
- '1'
- 'pre'
You might want to test min as well (which currently would be 1.6.0 and with this PR 1.10.0, in contrast to lts which is 1.10.10).

@dlfivefifty
Copy link
Member

I think testing 1.10.0 in addition to 1.10.10 is excessive. If a bug is ever triggered only in 1.10.0 it's not a good use of anyones time to fix it.

@devmotion
Copy link
Contributor

If a bug is ever triggered only in 1.10.0 it's not a good use of anyones time to fix it.

In principle, you don't have to fix anything apart from correcting the Julia compat entry: If the package does not support 1.10.0, it should not be declared to be compatible with 1.10.0.

Currently, the problem is even more sever as not testing min means that not only versions 1.10.0 - 1.10.9 but all of 1.6.0 - 1.10.9 are not tested. If you'd like to reduce CI times, IMO it would actually be better to skip pre and/or to test min and 1 instead of lts and 1 (based on the assumption that if e.g. tests pass with 1.10.0 they most likely also pass with 1.10.10).

@dlfivefifty
Copy link
Member

I agree that in theory we should be testing v1.6.x right now. But one can argue if a version of Julia is no longer supported then there shouldn't be an expectation that packages continue to work

I'm less worried about CI time than I am additional developer burden. Every extra test is an extra point of failure...

dlfivefifty pushed a commit that referenced this pull request Oct 31, 2025
Continued from #397. In addition to #397, the PR cleans `VERSION`
branches and updates CI.

---------

Co-authored-by: Jishnu Bhattacharya <jishnub.github@gmail.com>
@dlfivefifty
Copy link
Member

can this be closed?

@jishnub jishnub closed this Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants