ensure type in array convert #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release-1.0 #237 +/- ##
==============================================
Coverage ? 99.23%
==============================================
Files ? 5
Lines ? 657
Branches ? 0
==============================================
Hits ? 652
Misses ? 5
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dlfivefifty
added a commit
that referenced
this pull request
Mar 30, 2023
* StepRangeLen to support 0 step size in cumsum #226 (#230) * use StepRangeLen to support 0 step size * v0.13.11 * allow special casing on ∞ length * Restore ± special cases * Update runtests.jl * fix more tests * Update runtests.jl * Structured Broadcasting (#228) * Structured Broadcasting * add jishnubs tests * Update runtests.jl * Fix #97 by adding promote_rules (#234) * Move OneElement from Zygote and overload setindex (#161) (#235) * Add Zeros(T, n...) and Ones(T, n...) constructors (#94( (#233) * Add Zeros(T, n...) and Ones(T, n...) constructors (#94( * increase coverage * Update README.md * Move over OneElement from Zygote * Add tests * Update oneelement.jl * add tests * Update runtests.jl * add docs * ensure type in array convert (#237) * increase coverage * add convert tests * v1.0 * `_fill_dot` support general vectors (#229) * Update fillalgebra.jl * promote_op * add breaking test * add breaking test * fix * accept round-off errors * Update test/runtests.jl Co-authored-by: Sheehan Olver <solver@mac.com> * update * support inf and nan * fix 1.6 * Update fillalgebra.jl * Update fillalgebra.jl * trying to fix Julia 1.6 * comments * Update runtests.jl * add @inferred --------- Co-authored-by: Sheehan Olver <solver@mac.com> --------- Co-authored-by: Jishnu Bhattacharya <jishnub.github@gmail.com> Co-authored-by: Tianyi Pu <44583944+putianyi889@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is to disallow
Array(::Fill)from returning anything other than anArray. This would mean that the following won't work anymore:Also, This PR adds some docstrings.