Don't reference SizedArray parent type parameter if it doesn't have one #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
=======================================
Coverage 84.47% 84.47%
=======================================
Files 11 11
Lines 1546 1546
=======================================
Hits 1306 1306
Misses 240 240
Continue to review full report at Codecov.
|
Tokazama
reviewed
Apr 27, 2021
Member
Tokazama
left a comment
Tokazama
left a comment
There was a problem hiding this comment.
This looks good. It would be nice if at some point we could get the basic traits just implemented in StaticArrays, then changes in other packages wouldn't fall on us.
Collaborator
Author
|
I agree. It'd be great if we could drop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146