Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inverse chebyshev transform plan for Dual #904

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Add inverse chebyshev transform plan for Dual #904

merged 3 commits into from
Aug 17, 2023

Conversation

LucasAschenbach
Copy link
Contributor

I have added a method for the inverse Chebyshev transform plan on dual vectors to support transforming functionals with dual number coefficients to the value space.

This issue came up when trying to multiply two functionals with enough non-zero dual coefficients to convert to the value space.

@jishnub
Copy link
Member

jishnub commented Aug 11, 2023

Thanks! Could you add a test?

@LucasAschenbach
Copy link
Contributor Author

Sure!

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.30% 🎉

Comparison is base (0e78219) 28.06% compared to head (aed75c8) 28.36%.
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
+ Coverage   28.06%   28.36%   +0.30%     
==========================================
  Files          11       11              
  Lines         563      564       +1     
==========================================
+ Hits          158      160       +2     
+ Misses        405      404       -1     
Files Changed Coverage Δ
ext/ApproxFunDualNumbersExt.jl 21.27% <100.00%> (+3.88%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasAschenbach
Copy link
Contributor Author

I have added a test for the inverse Chebyshev transform on dual numbers. Should I keep the comment or remove it?

@jishnub
Copy link
Member

jishnub commented Aug 17, 2023

I think the comment is helpful

@jishnub
Copy link
Member

jishnub commented Aug 17, 2023

Could you also bump the patch version?

@LucasAschenbach
Copy link
Contributor Author

Do you mean setting the package version to 0.13.23?

@jishnub
Copy link
Member

jishnub commented Aug 17, 2023

Yes, exactly. I'll tag a release after merging

@LucasAschenbach
Copy link
Contributor Author

Done 👍

@jishnub
Copy link
Member

jishnub commented Aug 17, 2023

Thanks for the PR!

@jishnub jishnub merged commit 94db178 into JuliaApproximation:master Aug 17, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants