-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inverse chebyshev transform plan for Dual #904
Conversation
Thanks! Could you add a test? |
Sure! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #904 +/- ##
==========================================
+ Coverage 28.06% 28.36% +0.30%
==========================================
Files 11 11
Lines 563 564 +1
==========================================
+ Hits 158 160 +2
+ Misses 405 404 -1
☔ View full report in Codecov by Sentry. |
I have added a test for the inverse Chebyshev transform on dual numbers. Should I keep the comment or remove it? |
I think the comment is helpful |
Could you also bump the patch version? |
Do you mean setting the package version to |
Yes, exactly. I'll tag a release after merging |
Done 👍 |
Thanks for the PR! |
I have added a method for the inverse Chebyshev transform plan on dual vectors to support transforming functionals with dual number coefficients to the value space.
This issue came up when trying to multiply two functionals with enough non-zero dual coefficients to convert to the value space.