Skip to content
This repository has been archived by the owner on Jun 22, 2021. It is now read-only.

Improve error reporting in coerce for unsupported coercions #62

Closed
wants to merge 2 commits into from
Closed

Improve error reporting in coerce for unsupported coercions #62

wants to merge 2 commits into from

Conversation

OkonSamuel
Copy link
Member

closes issue #39

@codecov-io
Copy link

codecov-io commented Dec 19, 2020

Codecov Report

Merging #62 (394f012) into dev (3bd5193) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #62      +/-   ##
==========================================
- Coverage   98.91%   98.77%   -0.15%     
==========================================
  Files           7        7              
  Lines         277      245      -32     
==========================================
- Hits          274      242      -32     
  Misses          3        3              
Impacted Files Coverage Δ
src/coerce.jl 98.00% <100.00%> (+0.04%) ⬆️
src/convention/coerce.jl 98.70% <100.00%> (-0.25%) ⬇️
src/convention/scitype.jl 96.55% <0.00%> (-0.12%) ⬇️
src/init.jl 100.00% <0.00%> (ø)
src/schema.jl 100.00% <0.00%> (ø)
src/autotype.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bd5193...394f012. Read the comment docs.

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marvellously thorough work, @OkonSamuel. Many thanks. Closing in favour of #64 for a few tweaks.

@ablaom ablaom closed this Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants