Repository navigation
Remove warnings when resampling=Holdout(rng=...) - #22
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #22 +/- ##
==========================================
+ Coverage 95.29% 95.40% +0.10%
==========================================
Files 6 6
Lines 170 174 +4
==========================================
+ Hits 162 166 +4
Misses 8 8
Continue to review full report at Codecov.
|
This was referenced May 26, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In light of JuliaAI/MLJBase.jl#559, this PR removes warnings added to mitigate #12, which did not really resolve the issue, but which the recent MLJBase PR renders moot.
Specifically,
resamplingcan now benothing, anyHoldout, or any vector of the form[(train, test), ], wheretrainandtestare vectors of valid row indices for the data, and there will be no "cold restart" issues.