Skip to content

Commit

Permalink
Removing multithreading from julia-runtest step
Browse files Browse the repository at this point in the history
  • Loading branch information
@pebeto
pebeto committed Aug 21, 2023
1 parent a3307e6 commit c51341c
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/CI.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ jobs:
${{ runner.os }}-
- uses: julia-actions/julia-buildpkg@v1
- uses: julia-actions/julia-runtest@v1
env:
JULIA_NUM_THREADS: 2
- uses: julia-actions/julia-processcoverage@v1
- uses: codecov/codecov-action@v2
with:
Expand Down

2 comments on commit c51341c

@ablaom
Copy link
Member

@ablaom ablaom commented on c51341c Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm. If you need to remove this to get tests working, it sounds like there is still a race condition somewhere that could hit users. It's very normal to have multiple Julia threads enabled.

@pebeto
Copy link
Member Author

@pebeto pebeto commented on c51341c Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it is an issue related with HTTP.jl just for Julia 1.6. I wrote an issue in that project repo (JuliaWeb/HTTP.jl#1096).

Please sign in to comment.