Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to evaluate standard error calculation to fix display issue #872

Merged
merged 4 commits into from
Dec 6, 2022

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Dec 5, 2022

Closes #871.

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2022

Codecov Report

Merging #872 (7ccc14d) into dev (d79f29b) will increase coverage by 0.13%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##              dev     #872      +/-   ##
==========================================
+ Coverage   85.24%   85.38%   +0.13%     
==========================================
  Files          40       40              
  Lines        3558     3557       -1     
==========================================
+ Hits         3033     3037       +4     
+ Misses        525      520       -5     
Impacted Files Coverage Δ
src/resampling.jl 91.89% <75.00%> (+0.47%) ⬆️
src/measures/confusion_matrix.jl 94.59% <0.00%> (+2.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

test/resampling.jl Outdated Show resolved Hide resolved
test/resampling.jl Outdated Show resolved Hide resolved
ablaom and others added 2 commits December 6, 2022 09:33
minor formatting

Co-authored-by: Rik Huijzer <rikhuijzer@pm.me>
test/resampling.jl Outdated Show resolved Hide resolved
Co-authored-by: Rik Huijzer <rikhuijzer@pm.me>
@ablaom ablaom merged commit 7988b9c into dev Dec 6, 2022
@ablaom ablaom deleted the confmatrix-and-evaluate branch December 6, 2022 22:02
@ablaom
Copy link
Member Author

ablaom commented Dec 6, 2022

@rikhuijzer Thank you for reviewing and improving this PR.

@ablaom ablaom mentioned this pull request Dec 6, 2022
@rikhuijzer
Copy link
Member

@rikhuijzer Thank you for reviewing and improving this PR.

Thank you for your work on MLJ ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

evaluate errors displaying when using confusion_matrix as measure
3 participants