Skip to content

Better errors for no training loss - #53

Merged
ablaom merged 2 commits into
devfrom
better-errors-for-no-training-loss
Nov 12, 2021
Merged

ablaom merged 2 commits into
devfrom
better-errors-for-no-training-loss

Conversation

@ablaom

@ablaom ablaom commented Nov 12, 2021

Copy link
Copy Markdown
Member

@codecov-commenter

codecov-commenter commented Nov 12, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #53 (6fe9bda) into dev (1bff2cc) will decrease coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #53      +/-   ##
==========================================
- Coverage   96.23%   95.91%   -0.32%     
==========================================
  Files           8        8              
  Lines         292      294       +2     
==========================================
+ Hits          281      282       +1     
- Misses         11       12       +1     
Impacted Files Coverage Δ
src/controls.jl 98.58% <100.00%> (+0.02%) ⬆️
src/train.jl 95.45% <0.00%> (-4.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bff2cc...6fe9bda. Read the comment docs.

@ablaom
ablaom merged commit 8aa4bec into dev Nov 12, 2021
@ablaom ablaom mentioned this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Catch models that do not overload training_losses, reporting informative error message

2 participants