Skip to content

Bump EarlyStopping version and fix tests - #49

Merged
ablaom merged 4 commits into
devfrom
early-stopping-bump-and-test-fixes
Oct 27, 2021
Merged

ablaom merged 4 commits into
devfrom
early-stopping-bump-and-test-fixes

Conversation

@ablaom

@ablaom ablaom commented Oct 27, 2021 •

Copy link
Copy Markdown
Member

The new EarlyStopping release fixes bugs. This PR also re-instantes some broken tests which the new release also fixes.

cc @awadell1

Needs:

  • New 0.2 release of EarlyStopping.jl

@ablaom
ablaom marked this pull request as draft October 27, 2021 01:01
@ablaom ablaom closed this Oct 27, 2021
@ablaom ablaom reopened this Oct 27, 2021
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #49 (2be9f57) into dev (dce4dfc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #49   +/-   ##
=======================================
  Coverage   96.30%   96.30%           
=======================================
  Files           8        8           
  Lines         298      298           
=======================================
  Hits          287      287           
  Misses         11       11           
Impacted Files Coverage Δ
src/train.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dce4dfc...2be9f57. Read the comment docs.

@ablaom
ablaom marked this pull request as ready for review October 27, 2021 20:58
@ablaom
ablaom merged commit ea3d8a1 into dev Oct 27, 2021
@ablaom ablaom mentioned this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants