Skip to content

Multithreading for random forest predictions - #188

Merged
ablaom merged 7 commits into
devfrom
salbert83-master
Jul 18, 2022
Merged

ablaom merged 7 commits into
devfrom
salbert83-master

Conversation

@ablaom

@ablaom ablaom commented Jul 18, 2022

Copy link
Copy Markdown
Member

Replaces #176 after rebasing off dev

salbert83 and others added 7 commits July 18, 2022 13:00
Perhaps it is best to let the client decide whether they wish to use multithreading?
Good idea!

Co-authored-by: Okon Samuel <39421418+OkonSamuel@users.noreply.github.com>
Co-authored-by: Okon Samuel <39421418+OkonSamuel@users.noreply.github.com>
@codecov-commenter

codecov-commenter commented Jul 18, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #188 (5811020) into dev (33bbec4) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #188      +/-   ##
==========================================
+ Coverage   89.65%   89.67%   +0.02%     
==========================================
  Files          10       10              
  Lines        1179     1182       +3     
==========================================
+ Hits         1057     1060       +3     
  Misses        122      122              
Impacted Files Coverage Δ
src/classification/main.jl 97.92% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33bbec4...5811020. Read the comment docs.

@ablaom
ablaom merged commit 9e77eac into dev Jul 18, 2022
This was referenced Jul 18, 2022
@tecosaur

tecosaur commented Aug 2, 2022

Copy link
Copy Markdown

Did anyone test the multithreaded scaling of apply_forest IIRC I tried it (months ago) and found it was pretty bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants