Repository navigation
Conversation
Fix typo in `print_tree` description
…into rikhuijzer-rh/l-r
Co-authored-by: Anthony Blaom, PhD <anthony.blaom@gmail.com>
Round digits in `print_tree`
* Test multiple rngs * Add comment * Fix rng not being passed correctly * Revert some changes * Update comment * Extend tests * Simplify test * Lower accuracy bound * Fix a bug in the usage of Mersenne Twister * Fix tests * Use some more StableRNG * Use some more StableRNG * Use some more StableRNG * Use some more StableRNG * Use some more StableRNG * Use some more StableRNG * Fix Julia 1.6 * Use `StableRNG` in test/classification/adult * Use `StableRNG` for data generation too * Put old numbers back * Add one more rng
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
==========================================
- Coverage 89.51% 89.40% -0.12%
==========================================
Files 10 10
Lines 992 1000 +8
==========================================
+ Hits 888 894 +6
- Misses 104 106 +2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nfoldsCVpasses the RNG on toAdaBoostClassifiermodels. Fix non-threadsafe use of RNGs in random forests (Test multiple seeds #174) @rikhuijzerStableRNGsto ensure consistency across Julia versions and introduce tests over multiple seeds (Test multiple seeds #174) @rikhuijzerprint_tree(making it consistent with the AbstractTrees.jl fallback) and fix docstring (Fix typo inprint_treedescription #171, ReplaceLby<andRby≥#172, Round digits inprint_tree#173) @rikhuijzer