Repository navigation
Retain Policy-based graph drafts independently of chats - #471
Conversation
Signed-off-by: kikashy <kikashy@hotmail.com>
Signed-off-by: kikashy <kikashy@hotmail.com>
Signed-off-by: kikashy <kikashy@hotmail.com>
Signed-off-by: kikashy <kikashy@hotmail.com>
Integrate lifecycle 4d60cbb while preserving origin-scoped Graph custody and both Policy interpretation actions. Resolve PolicyPage with the Lifecycle tab and shared pending-operation guards. Signed-off-by: kikashy <kikashy@hotmail.com>
|
Reviewed combined head: Codex review completed for graph custody, source identity, write ordering/recovery, folder/helper ownership and the PolicyPage integration. This is same-vendor review, not a different-vendor attestation. Resolved findings include: acknowledge helper chat checkpoints before public dispatch/navigation; preserve an immutable pending save candidate and reconcile history without a second public write; scope folder and helper identity to originating chat plus draft ID; distinguish a bare saved-graph workspace from a legacy draft workspace; retain ambiguous legacy placements without assigning both drafts and remove aliases only when every owner is explicitly deleted. Folder v3 is explicit; v1/v2 remain readable. Existing explicit saved-graph placement wins. Validation: relevant native Go custody/migration/auth/CAS/restore and graph-write checks, 72 focused Web tests plus the final projection regression, and 38 overlap tests after integrating lifecycle. TypeScript, production build and localization checks passed. The only merge conflict was PolicyPage; both interpretation actions, Lifecycle and pending-operation guards remain. The single combined binary (
Original and combined evidence remain under No live Desk activation, portable Policy adoption or execution-admission enforcement is claimed. Spec PR212 remains Draft. Private format/downgrade and English locale-fallback limits are documented. |
Signed-off-by: kikashy <kikashy@hotmail.com>
|
Delta review: The Plan test now requires exactly one GET of the private graph draft store before the user's action; runtime/model/write dispatch remains forbidden. Library fixtures provide the unrelated empty private record so existing service-failure/retained-row/retry assertions still run unchanged. The delete-dialog fixture supplies the same QueryClient provider used by the app; its failed-save retention assertions remain intact. All 42 affected tests and TypeScript pass. Same-vendor review found no remaining issue in this delta. #470 is merged as |
|
🎉 Thank you for your contribution to Judgment Pack! If you’d like another task, choose a path that interests you: |
Start ordinary graph authoring from an exact retained Policy revision or publication, through the manual page or a reviewed chat handoff. The request stays unsent and uses the existing execution/context/Plan/Ask me controls.
Graph drafts and their private Policy sources now survive deletion of the originating chat, refresh and reopening from Library. Draft identity includes its originating chat; saved-source matching uses exact graph bytes. Reviewed saves retain an immutable pending candidate before dispatch and reconcile uncertain private finalization without repeating a public graph write. Helper conversations are acknowledged before navigation. Folder placement follows the scoped draft identity and handles ambiguous legacy assignments without assigning them to multiple drafts.
Validation: focused Go custody/migration/auth/CAS and graph confirmation checks, focused Web/context/Plan/recovery checks, TypeScript, localization and production build. Isolated browser and restart checks pass, including against the combined implementation; exact build/review evidence is recorded in the PR comments. Full CI runs on the PR.
Policy sources are private authoring provenance, not governing adoption, complete coverage or Graph Job authority. New private fields and scoped folder data require the current Desk build; older strict builds may refuse them rather than silently discard history. New UI messages use English fallback in the other locales.
Closes #468. Part of #455.