Make canonicalizedResource lower-case (Azure#26802)

* Make canonicalizedResource lower-case
Juancpani · Feb 4, 2022 · 68da1ac · 68da1ac
1 parent c2e25ba
commit 68da1ac
Show file tree

Hide file tree

Showing 10 changed files with 754 additions and 5 deletions.
diff --git a/sdk/tables/Azure.Data.Tables/CHANGELOG.md b/sdk/tables/Azure.Data.Tables/CHANGELOG.md
@@ -7,6 +7,7 @@
 ### Breaking Changes
 
 ### Bugs Fixed
+- Fixed an issue that caused authenticate failures when using a SAS token with a table name that contains upper-case characters. ([#26791](https://github.com/Azure/azure-sdk-for-net/issues/26791))
 
 ### Other Changes
 

diff --git a/sdk/tables/Azure.Data.Tables/src/Sas/TableSasBuilder.cs b/sdk/tables/Azure.Data.Tables/src/Sas/TableSasBuilder.cs
@@ -41,7 +41,7 @@ public TableSasBuilder(string tableName, string rawPermissions, DateTimeOffset e
             Argument.AssertNotNullOrEmpty(tableName, nameof(tableName));
             Argument.AssertNotNullOrEmpty(rawPermissions, nameof(tableName));
 
-            TableName = tableName.ToLowerInvariant();
+            TableName = tableName;
             ExpiresOn = expiresOn;
             Permissions = rawPermissions.ToLowerInvariant();
         }
@@ -256,7 +256,7 @@ public string Sign(TableSharedKeyCredential sharedKeyCredential) =>
         /// </returns>
         private static string GetCanonicalName(string account, string tableName) =>
             // Table: "/table/account/tablename"
-            string.Join("", new[] { "/table/", account, "/", tableName });
+            string.Join("", new[] { "/table/", account, "/", tableName.ToLowerInvariant() });
 
         /// <summary>
         /// Returns a string that represents the current object.

diff --git a/...ientLiveTests(Storage)/ValidateSasCredentialsWithGenerateSasUriAndUpperCaseTableName.json b/...ientLiveTests(Storage)/ValidateSasCredentialsWithGenerateSasUriAndUpperCaseTableName.json
diff --git a/...iveTests(Storage)/ValidateSasCredentialsWithGenerateSasUriAndUpperCaseTableNameAsync.json b/...iveTests(Storage)/ValidateSasCredentialsWithGenerateSasUriAndUpperCaseTableNameAsync.json